EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.


In, @hfinkel wrote:

> In, @mclow.lists wrote:
> > And is there any reason why `__libcpp_isinf` can't just return `false` for 
> > non-fp types?
> For custom numeric types that have an isinf, etc. found by ADL, they should 
> continue to work.

Do we already support custom numeric types? If so could you add a test for this 
under `test/libcxx`? Just a simple test case that instantiates the functions 
and shows it compiles.

Comment at: include/cmath:593
@@ +592,3 @@
+typename std::enable_if<!std::is_floating_point<_A1>::value, bool>::type
+__libcpp_isnan(_A1 __lcpp_x) _NOEXCEPT
nit: the `std::` qualifier on types is unnecessary.

cfe-commits mailing list

Reply via email to