majnemer added a subscriber: majnemer.
majnemer added a comment.
In https://reviews.llvm.org/D24693#548739, @ahatanak wrote:
> Do we want to remove lifetime intrinsics when we aren't doing the
> asan-use-after-scope check? Since this isn't a mis-compile caused by
> inaccurate lifetime intrinsics, I was wondering whether we should do this
> only when asan-use-after-scope is on to minimize the impact on compile time.
This doesn't sound right. Given the example in the description, we are
accessing the memory location after end has been called: this seems like a real
miscompile. It would appear unsafe to only do this for asan.
cfe-commits mailing list