BillyONeal created this revision. BillyONeal added reviewers: EricWF, mclow.lists. BillyONeal added a subscriber: cfe-commits.
The string_view::copy test calls std::min, which is not required to be made available by including <string_view>. (The MSVC++ STL does not use std::min internally because we need to avoid the *macro* named min which is defined by windows.h) https://reviews.llvm.org/D25531 Files: test/std/strings/string.view/string.view.ops/copy.pass.cpp Index: test/std/strings/string.view/string.view.ops/copy.pass.cpp =================================================================== --- test/std/strings/string.view/string.view.ops/copy.pass.cpp +++ test/std/strings/string.view/string.view.ops/copy.pass.cpp @@ -19,6 +19,7 @@ #include <string_view> +#include <algorithm> #include <cassert> #include "test_macros.h"
Index: test/std/strings/string.view/string.view.ops/copy.pass.cpp =================================================================== --- test/std/strings/string.view/string.view.ops/copy.pass.cpp +++ test/std/strings/string.view/string.view.ops/copy.pass.cpp @@ -19,6 +19,7 @@ #include <string_view> +#include <algorithm> #include <cassert> #include "test_macros.h"
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
