vleschuk marked an inline comment as done.
vleschuk added inline comments.
Comment at: include/clang/AST/ASTContext.h:83
- unsigned Align;
+ llvm::DIAlignment Align;
bool AlignIsRequired : 1;
> I'm not sure we want to use a debug info type inside the AST. I think we only
> want to use them in CGDebugInfo.cpp.
We use TypeInfo and related functions heavily in CGDebugInfo.cpp, leaving this
field as "unsigned" will make us to perform conversions from "unsigned" to
llvm::DIAlignment, I think having this changed will result in simpler code.
cfe-commits mailing list