[PATCH] D19996: New clang option -mpie-copy-relocationss to indicate support for linker copy relocations when linking as PIE

[Mandeep Singh Grang via cfe-commits]

mgrang added inline comments.


================
Comment at: lib/Driver/Tools.cpp:4502
 
+  if (Args.hasFlag(options::OPT_mpie_copy_relocations, 
options::OPT_mno_pie_copy_relocations,
+                   false)) {
----------------
Please fix indentation.


================
Comment at: lib/Frontend/CompilerInvocation.cpp:589
       Args.hasArg(OPT_mincremental_linker_compatible);
+  Opts.PIECopyRelocations =
+      Args.hasArg(OPT_mpie_copy_relocations);
----------------
You should also check for the negative flag here:

Opts.PIECopyRelocations = Args.hasFlag(options::OPT_mpie_copy_relocations,      
  options::OPT_mno_pie_copy_relocations, false);


https://reviews.llvm.org/D19996



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits