[PATCH] D19996: New clang option -mpie-copy-relocationss to indicate support for linker copy relocations when linking as PIE

[Sriraman Tallam via cfe-commits]

tmsriram added inline comments.


================
Comment at: lib/Frontend/CompilerInvocation.cpp:589
       Args.hasArg(OPT_mincremental_linker_compatible);
+  Opts.PIECopyRelocations =
+      Args.hasArg(OPT_mpie_copy_relocations);
----------------
mgrang wrote:
> You should also check for the negative flag here:
> 
> Opts.PIECopyRelocations = Args.hasFlag(options::OPT_mpie_copy_relocations,    
>     options::OPT_mno_pie_copy_relocations, false);
mpie_copy_relocations is  the only CC1 flag here and that is pushed into CC1 
command after checking for the negative. 


https://reviews.llvm.org/D19996



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits