EricWF accepted this revision.
EricWF added a reviewer: EricWF.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM minus inline comments.
Thanks for working on this.
================
Comment at:
test/std/localization/locale.categories/facet.numpunct/locale.numpunct.byname/thousands_sep.pass.cpp:50
+ }
std::locale l(LOCALE_en_US_UTF_8);
{
----------------
I think we should reset the global locale so it's different than the one we
pass to `std::locale l(...)`. That way we're testing that we don't accidental
use the global locale.
https://reviews.llvm.org/D26979
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
