EricWF added a comment.

In https://reviews.llvm.org/D26979#603110, @vangyzen wrote:

> @EricWF, would you like to see anything more from me?  I could set up an LLVM 
> development environment on my Mac if you want me to run the unit tests on Mac.


Nope. Feel free to commit after adding the requested assertions.



================
Comment at: 
test/std/localization/locale.categories/facet.numpunct/locale.numpunct.byname/thousands_sep.pass.cpp:65
+        {
+            expected = *std::localeconv()->thousands_sep;
+            (void) std::setlocale(LC_NUMERIC, "C");
----------------
We should probably assert that `thousands_sep` isn't a multibyte character.


https://reviews.llvm.org/D26979



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to