rmaprath added inline comments.
================ Comment at: include/__threading_support:193 +// Execute once +int __libcpp_execute_once(__libcpp_exec_once_flag *flag, + void (*init_routine)(void)) { ---------------- EricWF wrote: > These should have `inline`. In fact all of the functions in this header must > be declared inline but have not been. Actually, all the declarations on this header have `_LIBCPP_THREAD_ABI_VISIBILITY` , which includes the `inline` modifier. I've forgotten to include any context with this patch though, that might've made it bit unclear. https://reviews.llvm.org/D27576 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits