EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land.
LGTM. ================ Comment at: test/CMakeLists.txt:58 if (LIBCXX_ENABLE_EXPERIMENTAL_LIBRARY) + set(LIBCXX_TEST_DEPS cxx_experimental) ---------------- I always prefer `set(LIBCXX_TEST_DEPS "")` to initialize an empty list. Then `list(APPEND LIBCXX_TEST_DEPS cxx_experimental)` to add new items. https://reviews.llvm.org/D27576 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
