On 19/12/16 17:55, David Blaikie wrote:


On Thu, Dec 15, 2016 at 2:18 PM Sean Callanan via Phabricator via cfe-commits <cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org>> wrote:

    spyffe updated this revision to Diff 81661.
    spyffe marked 2 inline comments as done.
    spyffe added a comment.
    Herald added a subscriber: jgosnell.

    Applied Vassil and Vedant's comments.  I will commit this soon.


Was this change approved/accepted by anyone? "commit if no one has objections in <time frame>" isn't generally how LLVM project changes are reviewed/committed.
I could have greenlit this (as I personally pinged Sean on this patch. I need some of it to make progress on the libInterpreter part) :(



    Repository:
      rL LLVM

    https://reviews.llvm.org/D27180

    Files:
      test/Import/clang-flags/Inputs/S.c
      test/Import/clang-flags/test.c
      test/Import/empty-struct/Inputs/S.c
      test/Import/empty-struct/test.c
      test/Import/error-in-expression/Inputs/S.c
      test/Import/error-in-expression/test.c
      test/Import/error-in-import/Inputs/S.c
      test/Import/error-in-import/test.c
      test/Import/missing-import/test.c
      tools/CMakeLists.txt
      tools/clang-import-test/CMakeLists.txt
      tools/clang-import-test/clang-import-test.cpp

    _______________________________________________
    cfe-commits mailing list
    cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org>
    http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to