Reverted by 290130. I have new comments from Aleksei in https://reviews.llvm.org/D27180 <https://reviews.llvm.org/D27180>. I'll apply those and update the patch.
Sean > On Dec 19, 2016, at 9:48 AM, Sean Callanan <scalla...@apple.com> wrote: > > David, > > thanks for keeping an eye on this and sorry for the breach of process. > Would having Vassil approve the changelist (https://reviews.llvm.org/D27180 > <https://reviews.llvm.org/D27180>) be appropriate? > Let's say if he has any concerns or can't get to it by tomorrow, we revert my > patches since they're pretty self-contained. > > Sean > >> On Dec 19, 2016, at 8:55 AM, David Blaikie <dblai...@gmail.com >> <mailto:dblai...@gmail.com>> wrote: >> >> >> >> On Thu, Dec 15, 2016 at 2:18 PM Sean Callanan via Phabricator via >> cfe-commits <cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org>> >> wrote: >> spyffe updated this revision to Diff 81661. >> spyffe marked 2 inline comments as done. >> spyffe added a comment. >> Herald added a subscriber: jgosnell. >> >> Applied Vassil and Vedant's comments. I will commit this soon. >> >> Was this change approved/accepted by anyone? "commit if no one has >> objections in <time frame>" isn't generally how LLVM project changes are >> reviewed/committed. >> >> >> >> Repository: >> rL LLVM >> >> https://reviews.llvm.org/D27180 <https://reviews.llvm.org/D27180> >> >> Files: >> test/Import/clang-flags/Inputs/S.c >> test/Import/clang-flags/test.c >> test/Import/empty-struct/Inputs/S.c >> test/Import/empty-struct/test.c >> test/Import/error-in-expression/Inputs/S.c >> test/Import/error-in-expression/test.c >> test/Import/error-in-import/Inputs/S.c >> test/Import/error-in-import/test.c >> test/Import/missing-import/test.c >> tools/CMakeLists.txt >> tools/clang-import-test/CMakeLists.txt >> tools/clang-import-test/clang-import-test.cpp >> >> _______________________________________________ >> cfe-commits mailing list >> cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org> >> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >> <http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits>
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
