llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang Author: Prabhu Rajasekaran (Prabhuk) <details> <summary>Changes</summary> There is no support for shared libraries for UEFI target. Remove the incorrect -dll flag set from UEFI toolchain. --- Full diff: https://github.com/llvm/llvm-project/pull/137872.diff 2 Files Affected: - (modified) clang/lib/Driver/ToolChains/UEFI.cpp (-3) - (modified) clang/test/Driver/uefi-constructed-args.c (-1) ``````````diff diff --git a/clang/lib/Driver/ToolChains/UEFI.cpp b/clang/lib/Driver/ToolChains/UEFI.cpp index a9d7e7892c5a6..fbef72e34a3b1 100644 --- a/clang/lib/Driver/ToolChains/UEFI.cpp +++ b/clang/lib/Driver/ToolChains/UEFI.cpp @@ -80,9 +80,6 @@ void tools::uefi::Linker::ConstructJob(Compilation &C, const JobAction &JA, // "Terminal Service Aware" flag is not needed for UEFI applications. CmdArgs.push_back("-tsaware:no"); - // EFI_APPLICATION to be linked as DLL by default. - CmdArgs.push_back("-dll"); - if (Args.hasArg(options::OPT_g_Group, options::OPT__SLASH_Z7)) CmdArgs.push_back("-debug"); diff --git a/clang/test/Driver/uefi-constructed-args.c b/clang/test/Driver/uefi-constructed-args.c index 44d2271e0c8ba..49ede47a8953e 100644 --- a/clang/test/Driver/uefi-constructed-args.c +++ b/clang/test/Driver/uefi-constructed-args.c @@ -11,5 +11,4 @@ // CHECK-SAME: "-subsystem:efi_application" // CHECK-SAME: "-entry:EfiMain" // CHECK-SAME: "-tsaware:no" -// CHECK-SAME: "-dll" // CHECK-SAME: "-debug" `````````` </details> https://github.com/llvm/llvm-project/pull/137872 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
