arsenm wrote: > > I am not ok with this being an error by default. > > I think compilation must fail when an unsupported and untested option is > specified. And that includes when the target is SPIR-V.
I would call it a supported and used option. The unsupported and untested pieces are in the HIP headers, and bugs in the downstream libraries should not infect the compiler. Wave64 codegen should always work. Regressing the option which already exists to require jumping through hoops to continue using is unreasonable. The option should not work for SPIRV, since it doesn't apply for the machine. In short I don't think the compiler should be doing anything here. The warning should be isolated to the problematic HIP headers https://github.com/llvm/llvm-project/pull/140185 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
