Author: Amr Hesham Date: 2025-05-21T18:46:42+02:00 New Revision: 9db6c325249946afc51209f4f66241fb0c688ff9
URL: https://github.com/llvm/llvm-project/commit/9db6c325249946afc51209f4f66241fb0c688ff9 DIFF: https://github.com/llvm/llvm-project/commit/9db6c325249946afc51209f4f66241fb0c688ff9.diff LOG: [CIR][NFC] Fix an unused variable warning (#140783) This fixes a warning where a variable assigned in 'if' statement wasn't referenced again, and where else is used when 'if' has returns statement in the if-else statement Added: Modified: clang/lib/CIR/CodeGen/CIRGenCXXExpr.cpp Removed: ################################################################################ diff --git a/clang/lib/CIR/CodeGen/CIRGenCXXExpr.cpp b/clang/lib/CIR/CodeGen/CIRGenCXXExpr.cpp index 33865728e4cdc..d3888baea5d5e 100644 --- a/clang/lib/CIR/CodeGen/CIRGenCXXExpr.cpp +++ b/clang/lib/CIR/CodeGen/CIRGenCXXExpr.cpp @@ -115,7 +115,7 @@ RValue CIRGenFunction::emitCXXMemberOrOperatorMemberCallExpr( thisPtr = emitLValue(base); } - if (const CXXConstructorDecl *ctor = dyn_cast<CXXConstructorDecl>(md)) { + if (isa<CXXConstructorDecl>(md)) { cgm.errorNYI(ce->getSourceRange(), "emitCXXMemberOrOperatorMemberCallExpr: constructor call"); return RValue::get(nullptr); @@ -129,29 +129,29 @@ RValue CIRGenFunction::emitCXXMemberOrOperatorMemberCallExpr( cgm.errorNYI(ce->getSourceRange(), "emitCXXMemberOrOperatorMemberCallExpr: trivial assignment"); return RValue::get(nullptr); - } else { - assert(md->getParent()->mayInsertExtraPadding() && - "unknown trivial member function"); } + + assert(md->getParent()->mayInsertExtraPadding() && + "unknown trivial member function"); } // Compute the function type we're calling const CXXMethodDecl *calleeDecl = md; const CIRGenFunctionInfo *fInfo = nullptr; - if (const auto *dtor = dyn_cast<CXXDestructorDecl>(calleeDecl)) { + if (isa<CXXDestructorDecl>(calleeDecl)) { cgm.errorNYI(ce->getSourceRange(), "emitCXXMemberOrOperatorMemberCallExpr: destructor call"); return RValue::get(nullptr); - } else { - fInfo = &cgm.getTypes().arrangeCXXMethodDeclaration(calleeDecl); } + fInfo = &cgm.getTypes().arrangeCXXMethodDeclaration(calleeDecl); + mlir::Type ty = cgm.getTypes().getFunctionType(*fInfo); assert(!cir::MissingFeatures::sanitizers()); assert(!cir::MissingFeatures::emitTypeCheck()); - if (const auto *dtor = dyn_cast<CXXDestructorDecl>(calleeDecl)) { + if (isa<CXXDestructorDecl>(calleeDecl)) { cgm.errorNYI(ce->getSourceRange(), "emitCXXMemberOrOperatorMemberCallExpr: destructor call"); return RValue::get(nullptr); _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
