================ @@ -624,8 +624,29 @@ struct CheckFallThroughDiagnostics { } }; -} // anonymous namespace +bool isKnownToAlwaysThrow(const FunctionDecl *FD) { + if (!FD->hasBody()) ---------------- erichkeane wrote:
It seems we have the ability to try A LOT harder in this function, so I'd like a FIXME at the top of it that says something like: "This is always going to be a best effort, at the moment it only handles a function that contains only a single-expression that is a 'throw', and then only in limited circumstances'. https://github.com/llvm/llvm-project/pull/145166 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits