================
@@ -5988,11 +5988,9 @@ bool clang::IsArmStreamingFunction(const FunctionDecl 
*FD,
     if (FD->hasAttr<ArmLocallyStreamingAttr>())
       return true;
 
-  if (const Type *Ty = FD->getType().getTypePtrOrNull())
----------------
hvdijk wrote:

This change looks like it should not be necessary for your main bugfix, this 
change looks like an micro-optimization based on the knowledge that we know 
`IsArmStreamingFunction` is now never called with a `FunctionDecl` that has a 
null type, is that right? If so, I do not think that this function should be 
assuming that. It may be right for all the code that is in Clang, but this 
function is available in the public headers, we cannot assume that we know all 
the places where it gets called.

https://github.com/llvm/llvm-project/pull/150592
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to