================
@@ -5988,11 +5988,9 @@ bool clang::IsArmStreamingFunction(const FunctionDecl 
*FD,
     if (FD->hasAttr<ArmLocallyStreamingAttr>())
       return true;
 
-  if (const Type *Ty = FD->getType().getTypePtrOrNull())
----------------
MacDue wrote:

> operator-> that returns the Type* has an explicit assert that the type is not 
> QualType():

Ah, okay :+1: 

> I'm happy to add an explicit assert in this function and to commit this as a 
> separate change though.

I think it'd still be good to add an assert here. It's not obvious that the 
`QualType` assertion is hit before you dereference `Type*` pointer (at a 
glance), and I think it's better to fail early.

https://github.com/llvm/llvm-project/pull/150592
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to