================ @@ -6,17 +6,17 @@ struct B {}; typedef void (type1)() noexcept(10 > 5); // CHECK: TypedefDecl {{.*}} type1 'void () noexcept(10 > 5)' -// CHECK-NEXT: `-ParenType {{.*}} -// CHECK-NEXT: `-FunctionProtoType {{.*}} 'void () noexcept(10 > 5)' exceptionspec_noexcept_true cdecl +// CHECK-NEXT: `-typeDetails: ParenType {{.*}} +// CHECK-NEXT: `-typeDetails: FunctionProtoType {{.*}} 'void () noexcept(10 > 5)' exceptionspec_noexcept_true cdecl // CHECK-NEXT: |-NoexceptExpr: ConstantExpr {{.*}} 'bool' // CHECK-NEXT: | `-value: Int 1 -// CHECK-NEXT: `-BuiltinType {{.*}} 'void' +// CHECK: `-functionDetails: cdeclReturnType {{.*}} 'void' ---------------- mizvekov wrote:
I agree the changes to the Textual AST dump don't seem helpful for its intended purpose. You could make your changes to the JSON AST node dumper only. Even then, a lot of the new information looks like it wouldn't be very interesting to most users and is quite extra verbose, so it could be hidden behind a flag. https://github.com/llvm/llvm-project/pull/152372 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits