================
@@ -6,17 +6,17 @@ struct B {};
 typedef void (type1)() noexcept(10 > 5);
 
 // CHECK:      TypedefDecl {{.*}} type1 'void () noexcept(10 > 5)'
-// CHECK-NEXT: `-ParenType {{.*}}
-// CHECK-NEXT:   `-FunctionProtoType {{.*}} 'void () noexcept(10 > 5)' 
exceptionspec_noexcept_true cdecl
+// CHECK-NEXT: `-typeDetails: ParenType {{.*}}
+// CHECK-NEXT:   `-typeDetails: FunctionProtoType {{.*}} 'void () noexcept(10 
> 5)' exceptionspec_noexcept_true cdecl
 // CHECK-NEXT:     |-NoexceptExpr: ConstantExpr {{.*}} 'bool'
 // CHECK-NEXT:     | `-value: Int 1
-// CHECK-NEXT:     `-BuiltinType {{.*}} 'void'
+// CHECK:     `-functionDetails:  cdeclReturnType {{.*}} 'void'
----------------
AaronBallman wrote:

Can you explain a bit about how this helps folks with the textual dumps? It 
looks like this is more for folks trying to script the results, but those uses 
should be using the JSON dump output because that's actually structured output. 
The text node dumper is mostly used by folks who are in a debugger and want 
more information about what's being debugged, and for them these extra 
"details" bits are likely to be noise.

https://github.com/llvm/llvm-project/pull/152372
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to