arphaman added inline comments.
================ Comment at: include/clang/Edit/EditedSource.h:50 + // Location of argument use inside the top-level macro + SourceLocation Use; + ---------------- I think a name like `UseLoc` is more appropriate. ================ Comment at: lib/Edit/EditedSource.cpp:80 + return ArgUse.Identifier == U.Identifier && + std::tie(ArgUse.ExpansionStack, ArgUse.Use) != + std::tie(U.ExpansionStack, U.Use); ---------------- Do you need to compare the entire expansion stack, or can you get away with just the comparison of the front of the stack? Repository: rL LLVM https://reviews.llvm.org/D34268 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
