alexshap marked 3 inline comments as done. alexshap added inline comments.
================ Comment at: lib/Edit/EditedSource.cpp:80 + return ArgUse.Identifier == U.Identifier && + std::tie(ArgUse.ExpansionStack, ArgUse.Use) != + std::tie(U.ExpansionStack, U.Use); ---------------- arphaman wrote: > Do you need to compare the entire expansion stack, or can you get away with > just the comparison of the front of the stack? yeah, you are right, we can compare only the fronts because the entire stack can be recovered from that (via calling SourceMgr.getImmediateExpansionRange - like what's going on inside EditedSource::deconstructMacroArgLoc) Repository: rL LLVM https://reviews.llvm.org/D34268 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
