================
@@ -65,8 +65,7 @@ class ExpandModularHeadersPPCallbacks::FileRecorder {
};
ExpandModularHeadersPPCallbacks::ExpandModularHeadersPPCallbacks(
- CompilerInstance *CI,
- IntrusiveRefCntPtr<llvm::vfs::OverlayFileSystem> OverlayFS)
+ CompilerInstance *CI, llvm::vfs::OverlayFileSystem &OverlayFS)
----------------
vbvictor wrote:
How could we know that original object of `OverlayFileSystem &` will outlive
this reference. From docs I assume that `IntrusiveRefCntPtr` has `shared_ptr`
semantics but this convertion to reference seems bugprone.
https://github.com/llvm/llvm-project/pull/163686
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
