mehdi_amini added a comment. In https://reviews.llvm.org/D35081#808189, @tejohnson wrote:
> > Alternatively (and likely preferably from a compile-time point of view to > > limit the list of import), we could keep a map of GUID->Summary and reuse > > it before trying to select a new callee. > > Yep, that was my third option. I only hesitate because it seems like it might > be better to select the prevailing copy when we can, but perhaps it doesn't > matter much. I'm not sure I understand what is your first option? Always selecting the prevailing copy? Unless doing a topological order for visiting (which I don't think we could reasonably do), I don't see how you can ensure that: on your first visit you may see the prevailing not eligible, but it may become eligible on the second visit, at which point you need to do something about the first copy you already selected. https://reviews.llvm.org/D35081 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
