tejohnson added a comment. In https://reviews.llvm.org/D35081#808789, @tejohnson wrote:
> In https://reviews.llvm.org/D35081#808517, @mehdi_amini wrote: > > > In https://reviews.llvm.org/D35081#808207, @tejohnson wrote: > > > > > My first option was if any copy is under the threshold, simply pick the > > > prevailing copy (it may be over threshold, but assume we want that one > > > anyway). Another possibility is to only allow importing of the prevailing > > > copy, if it is over the inst limit, too bad. The main reason I think that > > > could be better is when we have PGO - the prevailing copy would for sure > > > have the matched PGO data, but the non-prevailing copies may not. > > > > > > Ah makes sense, both way are fine with me. > > > > I'd rather limit to the prevailing copy though and too bad if it is over > > the limit, to avoid the possibility of too large importing just because > > there was a small non-prevailing somewhere, but likely a rare case. > > > SGTM. That's also very simple to implement. I've just been to swamped with > other things so far to do it. Just chatted with Yunlian, he is not blocked. https://reviews.llvm.org/D35436 https://reviews.llvm.org/D35081 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
