https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/169558
>From 7125398204f7d0d353f3f1f2a4bbed9a0cce0857 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat <[email protected]> Date: Tue, 25 Nov 2025 11:53:59 -0800 Subject: [PATCH 1/6] [OpenMP] Add docs for fb_nullify/fb_preserve --- clang/docs/OpenMPSupport.rst | 2 ++ clang/docs/ReleaseNotes.rst | 2 ++ 2 files changed, 4 insertions(+) diff --git a/clang/docs/OpenMPSupport.rst b/clang/docs/OpenMPSupport.rst index f7e6061044c6d..fe1fc0de9f1f6 100644 --- a/clang/docs/OpenMPSupport.rst +++ b/clang/docs/OpenMPSupport.rst @@ -580,6 +580,8 @@ implementation. | need_device_addr modifier for adjust_args clause | :part:`partial` | :none:`unclaimed` | Parsing/Sema: https://github.com/llvm/llvm-project/pull/143442 | | | | | https://github.com/llvm/llvm-project/pull/149586 | +-------------------------------------------------------------+---------------------------+---------------------------+--------------------------------------------------------------------------+ +| need_device_ptr modifier for adjust_args clause | :part:`partial` | :none:`unclaimed` | Parsing/Sema: https://github.com/llvm/llvm-project/pull/168905 | ++-------------------------------------------------------------+---------------------------+---------------------------+--------------------------------------------------------------------------+ | Prescriptive num_threads | :good:`done` | :none:`unclaimed` | https://github.com/llvm/llvm-project/pull/160659 | | | | | https://github.com/llvm/llvm-project/pull/146403 | | | | | https://github.com/llvm/llvm-project/pull/146404 | diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst index c80e060f6b7d2..aa039c3c8ad48 100644 --- a/clang/docs/ReleaseNotes.rst +++ b/clang/docs/ReleaseNotes.rst @@ -756,6 +756,8 @@ OpenMP Support - Updated parsing and semantic analysis support for ``nowait`` clause to accept optional argument in OpenMP >= 60. - Added support for ``default`` clause on ``target`` directive. +- Added support for OpenMP 6.0 ``fb_nullify`` and ``fb_preserve`` fallback + modifiers used with the ``need_device_ptr`` map modifier. Improvements ^^^^^^^^^^^^ >From d0d1c7244f49095fca38964d4f96a78202936138 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat <[email protected]> Date: Tue, 25 Nov 2025 12:58:42 -0800 Subject: [PATCH 2/6] Addressed review comments --- clang/docs/OpenMPSupport.rst | 2 +- clang/docs/ReleaseNotes.rst | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/clang/docs/OpenMPSupport.rst b/clang/docs/OpenMPSupport.rst index fe1fc0de9f1f6..fcdf68c42df59 100644 --- a/clang/docs/OpenMPSupport.rst +++ b/clang/docs/OpenMPSupport.rst @@ -580,7 +580,7 @@ implementation. | need_device_addr modifier for adjust_args clause | :part:`partial` | :none:`unclaimed` | Parsing/Sema: https://github.com/llvm/llvm-project/pull/143442 | | | | | https://github.com/llvm/llvm-project/pull/149586 | +-------------------------------------------------------------+---------------------------+---------------------------+--------------------------------------------------------------------------+ -| need_device_ptr modifier for adjust_args clause | :part:`partial` | :none:`unclaimed` | Parsing/Sema: https://github.com/llvm/llvm-project/pull/168905 | +| need_device_ptr modifier for adjust_args clause | :part:`partial` | :none:`unclaimed` | Clang Parsing/Sema: https://github.com/llvm/llvm-project/pull/168905 | +-------------------------------------------------------------+---------------------------+---------------------------+--------------------------------------------------------------------------+ | Prescriptive num_threads | :good:`done` | :none:`unclaimed` | https://github.com/llvm/llvm-project/pull/160659 | | | | | https://github.com/llvm/llvm-project/pull/146403 | diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst index aa039c3c8ad48..193fcdc56e1cf 100644 --- a/clang/docs/ReleaseNotes.rst +++ b/clang/docs/ReleaseNotes.rst @@ -756,8 +756,9 @@ OpenMP Support - Updated parsing and semantic analysis support for ``nowait`` clause to accept optional argument in OpenMP >= 60. - Added support for ``default`` clause on ``target`` directive. -- Added support for OpenMP 6.0 ``fb_nullify`` and ``fb_preserve`` fallback - modifiers used with the ``need_device_ptr`` map modifier. +- Added parsing and semantic analysis support for ``need_device_ptr`` modifier + to accept an optional fallback argument (``fb_nullify`` or ``fb_preserve``) + with OpenMP >= 61. Improvements ^^^^^^^^^^^^ >From 686d8acb8437b67d12c1c98f2f7ee33fa7181907 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat <[email protected]> Date: Tue, 25 Nov 2025 13:07:59 -0800 Subject: [PATCH 3/6] Addressed review comments --- clang/docs/OpenMPSupport.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/clang/docs/OpenMPSupport.rst b/clang/docs/OpenMPSupport.rst index fcdf68c42df59..954fa53a90531 100644 --- a/clang/docs/OpenMPSupport.rst +++ b/clang/docs/OpenMPSupport.rst @@ -580,7 +580,7 @@ implementation. | need_device_addr modifier for adjust_args clause | :part:`partial` | :none:`unclaimed` | Parsing/Sema: https://github.com/llvm/llvm-project/pull/143442 | | | | | https://github.com/llvm/llvm-project/pull/149586 | +-------------------------------------------------------------+---------------------------+---------------------------+--------------------------------------------------------------------------+ -| need_device_ptr modifier for adjust_args clause | :part:`partial` | :none:`unclaimed` | Clang Parsing/Sema: https://github.com/llvm/llvm-project/pull/168905 | +| need_device_ptr modifier for adjust_args clause | :part:`unclaimed` | :none:`unclaimed` | | +-------------------------------------------------------------+---------------------------+---------------------------+--------------------------------------------------------------------------+ | Prescriptive num_threads | :good:`done` | :none:`unclaimed` | https://github.com/llvm/llvm-project/pull/160659 | | | | | https://github.com/llvm/llvm-project/pull/146403 | @@ -633,7 +633,8 @@ implementation. | | | | RT: @abhinavgaba (https://github.com/llvm/llvm-project/pull/149036, | | | | | https://github.com/llvm/llvm-project/pull/158370) | +-------------------------------------------------------------+---------------------------+---------------------------+--------------------------------------------------------------------------+ - +| need_device_ptr modifier for adjust_args clause | :part:`unclaimed` | :none:`unclaimed` | Clang Parsing/Sema: https://github.com/llvm/llvm-project/pull/168905 | ++-------------------------------------------------------------+---------------------------+---------------------------+--------------------------------------------------------------------------+ OpenMP Extensions ================= >From 9bedb6d15cf09b39792bca54210800821148f179 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat <[email protected]> Date: Tue, 25 Nov 2025 13:23:35 -0800 Subject: [PATCH 4/6] Addressed review comments --- clang/docs/OpenMPSupport.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clang/docs/OpenMPSupport.rst b/clang/docs/OpenMPSupport.rst index 954fa53a90531..0dd22a63df0bd 100644 --- a/clang/docs/OpenMPSupport.rst +++ b/clang/docs/OpenMPSupport.rst @@ -633,7 +633,7 @@ implementation. | | | | RT: @abhinavgaba (https://github.com/llvm/llvm-project/pull/149036, | | | | | https://github.com/llvm/llvm-project/pull/158370) | +-------------------------------------------------------------+---------------------------+---------------------------+--------------------------------------------------------------------------+ -| need_device_ptr modifier for adjust_args clause | :part:`unclaimed` | :none:`unclaimed` | Clang Parsing/Sema: https://github.com/llvm/llvm-project/pull/168905 | +| need_device_ptr modifier for adjust_args clause | :part:`partial` | :none:`unclaimed` | Clang Parsing/Sema: https://github.com/llvm/llvm-project/pull/168905 | +-------------------------------------------------------------+---------------------------+---------------------------+--------------------------------------------------------------------------+ OpenMP Extensions >From 7c48ecf9d6c5365c65d4f1133b5bf493e9456023 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat <[email protected]> Date: Wed, 26 Nov 2025 05:17:36 -0800 Subject: [PATCH 5/6] Added the current PR to RN --- clang/docs/OpenMPSupport.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/clang/docs/OpenMPSupport.rst b/clang/docs/OpenMPSupport.rst index 0dd22a63df0bd..76390ceab1c09 100644 --- a/clang/docs/OpenMPSupport.rst +++ b/clang/docs/OpenMPSupport.rst @@ -633,7 +633,8 @@ implementation. | | | | RT: @abhinavgaba (https://github.com/llvm/llvm-project/pull/149036, | | | | | https://github.com/llvm/llvm-project/pull/158370) | +-------------------------------------------------------------+---------------------------+---------------------------+--------------------------------------------------------------------------+ -| need_device_ptr modifier for adjust_args clause | :part:`partial` | :none:`unclaimed` | Clang Parsing/Sema: https://github.com/llvm/llvm-project/pull/168905 | +| need_device_ptr modifier for adjust_args clause | :part:`partial` | :none:`unclaimed` | Clang Parsing/Sema: https://github.com/llvm/llvm-project/pull/168905 +| | | | https://github.com/llvm/llvm-project/pull/169558 +-------------------------------------------------------------+---------------------------+---------------------------+--------------------------------------------------------------------------+ OpenMP Extensions >From 6b475d2db13ae92bc7e21b3d20fb9e38cc01c763 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat <[email protected]> Date: Wed, 26 Nov 2025 06:04:45 -0800 Subject: [PATCH 6/6] Fix doc --- clang/docs/OpenMPSupport.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/clang/docs/OpenMPSupport.rst b/clang/docs/OpenMPSupport.rst index 76390ceab1c09..e7ca7b0bd0792 100644 --- a/clang/docs/OpenMPSupport.rst +++ b/clang/docs/OpenMPSupport.rst @@ -633,8 +633,8 @@ implementation. | | | | RT: @abhinavgaba (https://github.com/llvm/llvm-project/pull/149036, | | | | | https://github.com/llvm/llvm-project/pull/158370) | +-------------------------------------------------------------+---------------------------+---------------------------+--------------------------------------------------------------------------+ -| need_device_ptr modifier for adjust_args clause | :part:`partial` | :none:`unclaimed` | Clang Parsing/Sema: https://github.com/llvm/llvm-project/pull/168905 -| | | | https://github.com/llvm/llvm-project/pull/169558 +| need_device_ptr modifier for adjust_args clause | :part:`partial` | :none:`unclaimed` | Clang Parsing/Sema: https://github.com/llvm/llvm-project/pull/168905 | +| | | | https://github.com/llvm/llvm-project/pull/169558 | +-------------------------------------------------------------+---------------------------+---------------------------+--------------------------------------------------------------------------+ OpenMP Extensions _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
