mgcarrasco wrote: The refactoring for preventing code duplication around the `llvm-link` invocation LGTM. For the driver changes, I don't have much expertise yet on that. I'll let others review that.
In case it helps other reviewers, regarding functional changes, I understand that this PR is only meant to affect `Toolchains/SPIRV.cpp` for `-emit-llvm`, whereas `-emit-llvm -S` is unaffected. My feedback on `Driver.cpp` was meant to scope the changes only for the targeted toolchain (`Toolchains/SPIRV.cpp`) and prevent regressions. This seems to be implemented already (thanks @sarnex). I prefer more experienced developers to take a look at that. https://github.com/llvm/llvm-project/pull/169572 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
