================
@@ -24,7 +24,7 @@ namespace clang::tidy {
 /// them in the order of appearance in the list.
 class GlobList {
 public:
-  virtual ~GlobList() = default;
+  GlobList() = default;
----------------
vbvictor wrote:

Now if someone would use `GlobList*` as a pointer to derived, they get 
undeleted base object?

Could we either preserve virtual as is, or merge two classes into one and make 
it final 

https://github.com/llvm/llvm-project/pull/164212
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to