================
@@ -24,7 +24,7 @@ namespace clang::tidy {
/// them in the order of appearance in the list.
class GlobList {
public:
- virtual ~GlobList() = default;
+ GlobList() = default;
----------------
localspook wrote:
What I’m saying is *we don’t have any* cases where we access a `CachedGlobList`
through a `GlobList*`, that’s why it shouldn’t be virtual
https://github.com/llvm/llvm-project/pull/164212
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
