=?utf-8?q?João?= Saffran <[email protected]>, =?utf-8?q?João?= Saffran <[email protected]>, =?utf-8?q?João?= Saffran <[email protected]>, =?utf-8?q?João?= Saffran <[email protected]>, =?utf-8?q?João?= Saffran <[email protected]>, =?utf-8?q?João?= Saffran <[email protected]> Message-ID: In-Reply-To: <llvm.org/llvm/llvm-project/pull/[email protected]>
https://github.com/bogner commented: While the updates look correct, these tests mostly seem a bit suspicious. This isn't the place to test that we convert various types to float correctly, so I don't think any of the tests for overloads that don't exist make sense here. If we want to have tests to make sure we don't have extra overloads (that is, ones that HLSL doesn't define), then we should have a separate test that uses `-Wconversion` and checks that we have diagnostics for the conversions we expect. https://github.com/llvm/llvm-project/pull/177495 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
