================
@@ -1939,7 +1941,7 @@ static CharUnits computeOffsetHint(ASTContext &astContext,
// If the path contains a virtual base class we can't give any hint.
// -1: no hint.
if (pathElement.Base->isVirtual())
- return CharUnits::fromQuantity(-1ULL);
+ return CharUnits::fromQuantity( std::numeric_limits<uint64_t>::max());
----------------
andykaylor wrote:
I don't think this is right. This is using
`CharUnits::fromQuantity(QuantityType Quantity)` and `QuantityType` is
currently typedef'd as `int64_t`. I'm not sure why the code was using `-1ULL`
here but we should be able to just make it `-1LL` or even `-1`. There are
places in this file that use `-2ULL` and `-3ULL`. Those can be changed to
signed literals also.
https://github.com/llvm/llvm-project/pull/178225
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
