https://github.com/jmorse approved this pull request.
Thanks for sticking with this; github has done its favourite thing of chucking away half the comments, so it's a bit difficult to re-review. Looking at what I wrote last time, I think everything's been addressed, I would only add that you could put the explanation of the MetadataLoader.cpp `upgradeCULocals` function into a comment there for future reference. This LGTM, modulo Davids comments. https://github.com/llvm/llvm-project/pull/165032 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
