https://github.com/nikic commented:
Didn't get far, but a few initial comments. The PR description needs an update > @nikic I'm still considering merging this with CallBrPrepare, though CallBr > now handles more than just ASM instructions. :-) But keeping this separated > will help with the code review for this change. In other words, I can merge > the two afterwards as an NFC, but before the compiler release. :-) Not sure I get how that helps with review. I think if you just put your InlineAsmPrepare code into CallBrPrepare things would be a bit simpler because we don't need the pass boilerplate and pipeline test changes anymore? (Doing a CallBrPrepare -> InlineAsmPrepare as an NFC first would be good though.) https://github.com/llvm/llvm-project/pull/92040 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
