=?utf-8?q?Balázs_Kéri?= <[email protected]>, =?utf-8?q?Balázs_Kéri?= <[email protected]>, =?utf-8?q?Balázs_Kéri?= <[email protected]>, =?utf-8?q?Balázs_Kéri?= <[email protected]>, =?utf-8?q?Balázs_Kéri?= <[email protected]>, =?utf-8?q?Balázs_Kéri?= <[email protected]>, =?utf-8?q?Balázs_Kéri?= <[email protected]>, =?utf-8?q?Balázs_Kéri?= <[email protected]> Message-ID: In-Reply-To: <llvm.org/llvm/llvm-project/pull/[email protected]>
https://github.com/vbvictor commented: Thank you for working on this! Generally code/docs looks good. Please add ReleaseNotes about the new check. ----------------------------------------------------- In one of the comments I asked to add test case with more nested function calls and I wonder if we can print whole function/variable chain as notes to help users debug and fix warning. I suspect in real code bases it could be difficult to identify root cause if 10 functions are calling each other. ------------------------------------------------------ Also I worry a little about performance of this check. Could you please try running this check on some codebases to evaluate potential FPs and measure time with `--enable-check-profile`. https://github.com/llvm/llvm-project/pull/175342 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
