steakhal wrote:

> I am not pressing merge because the PR description is emtpy. Its probably by 
> design since the title is sufficient?

This is true. I didn't intend to add description this time.

From what I've seen, PR authors press the merge button. In some sense they know 
when they are available for the next couple hours to do the revert if needed.

Also, the author may want to apply final touches before merging.

So unless there is urgency, its better reserved for PR author.

(Notice that this is different from my stance of pushing to the PR branch. IMO 
that is fine as long as the changes are non contraversial and you do no force 
pushes to achieve that)

https://github.com/llvm/llvm-project/pull/181847
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to