https://github.com/ojhunt commented:
@Thibault-Monnier In general I'm convinced that this is worth taking in it's current general design, but I'd like to see whether we can move the space check inside the isHorizontalWhitespace function rather than having it placed in fairly ad hoc paths, similarly I'd like to see if the `LIKELY()` wrapper is actually necessary. Otherwise this LGTM Making this a comment as depending on the above answers it may not need changes https://github.com/llvm/llvm-project/pull/180819 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
