ojhunt wrote:

> @ojhunt, I tried both your proposals. Moving the space check into 
> `isHorizontalWhitespace` does not work as well, and is only slightly better 
> than `main`. Removing `LLVM_LIKELY` _did_ actually slightly increase 
> performance, so I kept it.
> 
> Is the current state of this OK with you?

yup!

depressing that it can't simply be in the main function, but I suspect there's 
a difference in behavior between skip whitespace in the "beginning of a line" 
vs everywhere else

https://github.com/llvm/llvm-project/pull/180819
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to