================
@@ -948,15 +948,16 @@ void CGHLSLRuntime::emitEntryFunction(const FunctionDecl 
*FD,
     OB.emplace_back("convergencectrl", bundleArgs);
   }
 
-  llvm::DenseMap<const DeclaratorDecl *, llvm::Value *> OutputSemantic;
+  llvm::DenseMap<const DeclaratorDecl *, std::pair<llvm::Value *, llvm::Type 
*>>
----------------
ojhunt wrote:

The more I look at this the less I like it (vs a struct with named fields), but 
it seems to be a reasonable common idiom.

@efriedma-quic @mizvekov do we have a policy on the use of pair/tuple in new 
code? Obviously my preference is structs with named fields, but I don't want to 
unnecessarily force new contributors to adopt my model of new structs if that's 
not something other folk are invested in?

https://github.com/llvm/llvm-project/pull/181740
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to