================
@@ -948,15 +948,16 @@ void CGHLSLRuntime::emitEntryFunction(const FunctionDecl 
*FD,
     OB.emplace_back("convergencectrl", bundleArgs);
   }
 
-  llvm::DenseMap<const DeclaratorDecl *, llvm::Value *> OutputSemantic;
+  llvm::DenseMap<const DeclaratorDecl *, std::pair<llvm::Value *, llvm::Type 
*>>
----------------
efriedma-quic wrote:

I don't think we have any policy on using pair/tuple.  It's probably worth 
defining a struct if it makes the code more readable.  If it's going to be used 
to define exactly one map, and we're going to iterate over that map exactly 
once a few lines later, I'm not sure how helpful it is.

I'm really confused what this "map" is supposed to be mapping, though.  The way 
the code is structured, the map has at most one key.

https://github.com/llvm/llvm-project/pull/181740
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to