https://github.com/evelez7 commented:
It's great to see enum value comments getting serialized in JSON but I think this patch should be broken up. I might be nitpicking, but there's at least three different things going on here: HTML getting enum value comments, MD getting enum value comments *and* values, and a header being added to MD tables even though I don't think the current MD syntax actually supports any flavor that has tables. It made the patch a bit difficult to reason about since I was looking at a few different concepts. I'm curious to know what @ilovepi thinks about the MD tables point since I actually don't know what the MD output is fed into. Also would be open to feedback on whether this patch is actually too broad or not, might just be me. https://github.com/llvm/llvm-project/pull/183085 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
