================
@@ -167,9 +184,31 @@ static void genMarkdown(const ClangDocContext &CDCtx, 
const EnumInfo &I,
 
   std::string Buffer;
   llvm::raw_string_ostream Members(Buffer);
-  if (!I.Members.empty())
-    for (const auto &N : I.Members)
-      Members << "| " << N.Name << " |\n";
+  if (!I.Members.empty()) {
+    OS << "| Name | Value |";
----------------
evelez7 wrote:

This actually doesn't result in valid Markdown tables, at least according to 
the GitHub flavor. Tables need hyphens below the headers. I also don't think 
this should be included in this patch. If we want to explicitly support the 
GitHub flavor here, then this should go in a different patch.

I actually never even connected that these should be tables. @ilovepi I 
remember someone saying this MD backend was actually used internally at Google, 
I think? Are these supposed to result in actual tables?

https://github.com/llvm/llvm-project/pull/183085
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to