================
@@ -460,66 +435,31 @@ bool SSPLayoutAnalysis::requiresStackProtector(Function
*F,
if (CI->isZero())
continue;
}
- if (AI->isArrayAllocation()) {
----------------
phyBrackets wrote:
this unconditionally protected all variable length allocas under basic
`-fstac-protector`, regardless of element type, new `containsProtectableArray`
does element type filtering on non-darwin linux, it rejects non char arrays, so
`int arr[n]` on linux with `-fstack-protector` was previously protected and is
now silently unprotected, that's a security regression, I assume the clang side
VLA codegen path would need to replicate the old type agnostic behavior for
variable length arrays.
https://github.com/llvm/llvm-project/pull/183623
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
