steakhal wrote:

> Are the files on the list correct?
> 
> Besides, when I was working on this PR, I found that `missing-z3-nocrash.c` 
> declares `REQUIRES: no-z3`


So these properties that `REQUIRES` can check against are defined as the 
`available_features` inside `clang/test/lit.cfg.py`. You can look for `z3` 
there. And I guess, it should add the `no-z3` if it's not present (and it 
actually does!).

We can move the `missing-z3-nocrash.c` under the `z3` directory.


> [...] while `print-ranges.cpp` and `PR24184.cpp` declare `UNSUPPORTED: z3`. 
> What are their differences?

AFAIK nothing. They are practically the same.
You should probably drop the `no-z3` logic and use `UNSUPPORTED: z3` instead. 
Nice catch.


https://github.com/llvm/llvm-project/pull/183724
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to