JonasToth added inline comments.
================ Comment at: clang-tidy/cppcoreguidelines/OwningMemoryCheck.cpp:294 + + diag(BadClass->getLocStart(), + "class with an 'gsl::owner<>' as member but without declared " ---------------- aaron.ballman wrote: > Instead of diagnosing this on the class, why not diagnose the individual > offending members (and then you don't need a note, either)? (Note, that may > change the suggested diagnostic wording below). yes, this is probably better. i plan to add deeper analysis, that `gsl::owner<>` will always be released or moved. That would check, if destructors do this correctly, so offending the member is the better way. https://reviews.llvm.org/D36354 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
