vbvictor wrote: While intent of the patch is highly appreciated I (too) a bit struggle with patch size for final approval. I wish we could have less than 200 additions or 400 addions + deleteons per patch. At least that is my humble mental limit I observed experimenttally (and try to stick to while refactoring)
If you dont want to create many branches manually and do repetitive work, you can check out this tool: https://github.com/vbvictor/acp, typical workflow could be: - stand on `main` with N unstaged files (with changes) - put N/4 files to staged and `acp pr "[clang-tidy][NFC] My patch (1/N)" -i` (-i for github pr page) - put other N/4 files... and repeat. You could notice its usage by branches named `acp/<user>/<hash>` https://github.com/llvm/llvm-project/pull/185169 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
