localspook wrote: > While intent of the patch is highly appreciated I (too) a bit struggle with > patch size for final approval. I wish we could have less than 200 additions > or 400 addions + deleteons per patch. At least that is my humble mental limit > I observed experimenttally (and try to stick to while refactoring)
Ah, yeah, sorry about that. If I do large refactors in the future, I'll try and split them up. (since this patch is already getting reviewed, I think it's not worth retroactively splitting *this* one up, but yeah). https://github.com/llvm/llvm-project/pull/185169 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
