================
@@ -367,9 +371,12 @@ static void 
serializeDescription(llvm::ArrayRef<CommentInfo> Description, json::
       if (TextCommentsArray.kind() == json::Value::Null ||
           TextCommentsArray.getAsArray()->empty())
         continue;
-      insertComment(Obj, TextCommentsArray, "ParagraphComments");
+      insertComment(DescriptionObj, TextCommentsArray, "ParagraphComments");
     }
   }
+  Obj["Description"] = std::move(DescriptionObj);
+  if (!Key.empty())
+    Obj[Key] = true;
----------------
ilovepi wrote:

This seems dubious. Doesn't this just add keys to all the descriptions? Isn't 
this also an EnumMemberComment? MemberComment sounds like it could be for 
classes too.

BTW, how is the JSON testing still passing? you added a new key, so I'd expect 
something needs to be updated.

https://github.com/llvm/llvm-project/pull/183085
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to