================
@@ -367,9 +371,12 @@ static void
serializeDescription(llvm::ArrayRef<CommentInfo> Description, json::
if (TextCommentsArray.kind() == json::Value::Null ||
TextCommentsArray.getAsArray()->empty())
continue;
- insertComment(Obj, TextCommentsArray, "ParagraphComments");
+ insertComment(DescriptionObj, TextCommentsArray, "ParagraphComments");
}
}
+ Obj["Description"] = std::move(DescriptionObj);
+ if (!Key.empty())
+ Obj[Key] = true;
----------------
ilovepi wrote:
> Do you mean renaming the key to `HasEnumMemberComments`? Since, we only use
> the key in enum-template.mustache, isn't `HasMemberComment` okay?
>
> > BTW, how is the JSON testing still passing? you added a new key, so I'd
> > expect something needs to be updated.
>
> Currently, enum.cpp does not contain any JSON tests.
Well, that's a problem then. you're changing JSON functionality w/o testing.
https://github.com/llvm/llvm-project/pull/183085
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
