bwendling wrote:

> Really, the big thing is that this significantly increases memory usage for 
> code that doesn't use the error attribute at all. And the codebases that are 
> hurt most by this are big C++ codebases which are least likely to use it in 
> the first place. If we can restrict this so big C++ codebases don't pay the 
> penalty somehow, I'm okay with having it on by default, but otherwise I want 
> it off by default.

Is this due to the Metadata added in `CGCall.cpp`? Maybe it if the 
`TargetDecl->hasAttr<ErrorAttr>()` conditional was re-added to the if-then 
statement it would help alleviate this. Or make this a C-only feature...

https://github.com/llvm/llvm-project/pull/174892
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to