yxsamliu wrote: The current patch causes a lot of churn in existing OpenMP and SYCL tests because emitting "called by" notes after each error significantly increases the note count. Looking at this more carefully, I noticed that the notes for different errors in the same function are actually the same since callers are tracked per function, not per error. For example:
``` error: ... (error #1) note: called by 'df1' note: called by 'df2' error: ... (error #2) note: called by 'df1' // same as above note: called by 'df2' // same as above ``` Both errors are in the same HD function, and df1/df2 both call that function, so every error gets the exact same caller list. Given that, maybe we should keep the original behavior of emitting the call chain once after all errors, and focus this PR on just the "in HD-promoted function" note instead. https://github.com/llvm/llvm-project/pull/187153 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
